Thanks Anand and Shashank, I applied this on master. > -----Original Message----- > From: Shashank Ram [mailto:[email protected]] > Sent: Tuesday, November 28, 2017 8:18 AM > To: Anand Kumar <[email protected]>; [email protected]; Alin > Serdean <[email protected]> > Subject: Re: [ovs-dev] [PATCH] datapath-windows: Account for VLAN tag in > tunnel Decap > > Alin, can we apply this patch? It’s been sitting around in the mailing list > for a > week without any reviews after an ACK. [Alin Serdean] Sure. Thanks for reminding me. > > -- > Thanks, > Shashank > > On 11/21/17, 11:18 PM, "Anand Kumar" <[email protected]> > wrote: > > Acked-by: Anand Kumar <[email protected]> > > Thanks, > Anand Kumar > > On 11/20/17, 3:06 PM, "[email protected] on behalf of > Shashank Ram" <[email protected] on behalf of > [email protected]> wrote: > > Decap functions for tunneling protocols do not compute > the packet header offsets correctly when there is a VLAN > tag in the L2 header. This results in incorrect checksum > computation causing the packet to be dropped. > > This patch adds support to account for the VLAN tag in the > packet if its present, and makes use of the OvsExtractLayers() > function to correctly compute the header offsets for different > layers. > > Testing done: > - Tested Geneve, STT, Vxlan and Gre and verified that there > are no regressions. > - Verified that packets with VLAN tags are correctly handled > in the decap code of all tunneling protocols. Previously, > this would result in packet drops due to invalid checksums > being computed. > - Verified that non-VLAN tagged packets are handled correctly. > > Signed-off-by: Shashank Ram <[email protected]>
_______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
