>From: Ilya Maximets [mailto:i.maxim...@samsung.com]
>Sent: Monday, December 11, 2017 1:19 PM
>To: ovs-dev@openvswitch.org
>Cc: Heetae Ahn <heetae82....@samsung.com>; Fischetti, Antonio
><antonio.fische...@intel.com>; Loftus, Ciara <ciara.lof...@intel.com>;
>Kavanagh, Mark B <mark.b.kavan...@intel.com>; Stokes, Ian
><ian.sto...@intel.com>; Wojciechowicz, RobertX
><robertx.wojciechow...@intel.com>; Flavio Leitner <f...@redhat.com>; Ilya
>Maximets <i.maxim...@samsung.com>
>Subject: [PATCH v4 1/2] vswitchd: Document netdev-dpdk commands.
>
>netdev-dpdk appctl commands added to man pages.
>
>Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>

LGTM.

Acked-by: Mark Kavanagh <mark.b.kavan...@intel.com>

>---
> NEWS                        | 1 +
> lib/automake.mk             | 1 +
> lib/netdev-dpdk-unixctl.man | 9 +++++++++
> manpages.mk                 | 2 ++
> vswitchd/ovs-vswitchd.8.in  | 1 +
> 5 files changed, 14 insertions(+)
> create mode 100644 lib/netdev-dpdk-unixctl.man
>
>diff --git a/NEWS b/NEWS
>index d45904e..69d5dab 100644
>--- a/NEWS
>+++ b/NEWS
>@@ -18,6 +18,7 @@ Post-v2.8.0
>    - DPDK:
>      * Add support for DPDK v17.11
>      * Add support for vHost IOMMU
>+     * All the netdev-dpdk appctl commands described in ovs-vswitchd man
>page.
>
> v2.8.0 - 31 Aug 2017
> --------------------
>diff --git a/lib/automake.mk b/lib/automake.mk
>index effe5b5..4b38a11 100644
>--- a/lib/automake.mk
>+++ b/lib/automake.mk
>@@ -465,6 +465,7 @@ MAN_FRAGMENTS += \
>       lib/db-ctl-base.man \
>       lib/dpctl.man \
>       lib/memory-unixctl.man \
>+      lib/netdev-dpdk-unixctl.man \
>       lib/ofp-version.man \
>       lib/ovs.tmac \
>       lib/service.man \
>diff --git a/lib/netdev-dpdk-unixctl.man b/lib/netdev-dpdk-unixctl.man
>new file mode 100644
>index 0000000..5af6eca
>--- /dev/null
>+++ b/lib/netdev-dpdk-unixctl.man
>@@ -0,0 +1,9 @@
>+.SS "NETDEV-DPDK COMMANDS"
>+These commands manage DPDK related ports (\fBtype=\fR\fIdpdk*\fR).
>+.IP "\fBnetdev-dpdk/set-admin-state\fR [\fIinterface\fR] \fBup\fR |
>\fBdown\fR"
>+Change the admin state for DPDK \fIinterface\fR to \fBup\fR or \fBdown\fR.
>+If \fIinterface\fR is not specified, then it applies to all DPDK ports.
>+.IP "\fBnetdev-dpdk/detach\fR \fIpci-address\fR"
>+Detaches device with corresponding \fIpci-address\fR from DPDK.  This command
>+can be used to detach device if it wasn't detached automatically after port
>+deletion. Refer to the documentation for details and instructions.
>diff --git a/manpages.mk b/manpages.mk
>index d610d88..c89bc45 100644
>--- a/manpages.mk
>+++ b/manpages.mk
>@@ -279,6 +279,7 @@ vswitchd/ovs-vswitchd.8: \
>       lib/daemon.man \
>       lib/dpctl.man \
>       lib/memory-unixctl.man \
>+      lib/netdev-dpdk-unixctl.man \
>       lib/service.man \
>       lib/ssl-bootstrap.man \
>       lib/ssl.man \
>@@ -296,6 +297,7 @@ lib/coverage-unixctl.man:
> lib/daemon.man:
> lib/dpctl.man:
> lib/memory-unixctl.man:
>+lib/netdev-dpdk-unixctl.man:
> lib/service.man:
> lib/ssl-bootstrap.man:
> lib/ssl.man:
>diff --git a/vswitchd/ovs-vswitchd.8.in b/vswitchd/ovs-vswitchd.8.in
>index c18baf6..76ccfcb 100644
>--- a/vswitchd/ovs-vswitchd.8.in
>+++ b/vswitchd/ovs-vswitchd.8.in
>@@ -283,6 +283,7 @@ port names, which this thread polls.
> .IP "\fBdpif-netdev/pmd-rxq-rebalance\fR [\fIdp\fR]"
> Reassigns rxqs to pmds in the datapath \fIdp\fR based on their current usage.
> .
>+.so lib/netdev-dpdk-unixctl.man
> .so ofproto/ofproto-dpif-unixctl.man
> .so ofproto/ofproto-unixctl.man
> .so lib/vlog-unixctl.man
>--
>2.7.4

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to