> > Currenlty, OVS snoops any ARP or ND packets in any bridge and populates > > the tunnel neighbor cache with the retreived data. For instance, when > > ARP reply originated by a tenant is received on an overlay bridge, the > > ARP message is snooped and tunnel neighbor cache is filled with tenant > > data, however only tunnel neighbor data should be stored there. > > In worst case tunnel peer data could be overwritten in the cache. Which > > triggers revalidation as well. > > > > This series resolves the issue, by trying to snoop ARP and ND messages > > addressing tunnel end point in current bridge. > > > > Zoltan Balogh (3): > > ofproto-dpif-sflow: propagate actions within clone > > tests: modify ARP snoop tests for tunneling with clone > > xlate: call tnl_neigh_snoop() from terminate_native_tunnel() > > > > include/sparse/netinet/in.h | 10 +++ > > lib/tnl-neigh-cache.c | 1 + > > ofproto/ofproto-dpif-sflow.c | 19 ++++-- > > ofproto/ofproto-dpif-sflow.h | 2 +- > > ofproto/ofproto-dpif-upcall.c | 2 +- > > ofproto/ofproto-dpif-xlate.c | 150 > > ++++++++++++++++++++++++++++++++++++++++-- > > tests/ofproto-dpif.at | 2 +- > > tests/tunnel-push-pop-ipv6.at | 78 ++++++++++++++++++++-- > > tests/tunnel-push-pop.at | 91 +++++++++++++++++++++---- > > 9 files changed, 319 insertions(+), 36 deletions(-) > > > > Zoltan, > > Thanks for your work on this. I have tested and reviewed your patches > and everything looks OK to me > except for some checkpatch errors on the first patch in the series. If > you can fix that up and resubmit > then I'll be happy to provide tested-by and reviewed-by acks. > > Thanks! > > - Greg
Hi Greg, Thank you for the review! I've seen the checkpatch warnings too. Actually, some of the lines in vanilla code do have tabs instead of spaces. I modified some of these lines and kept the leading tabs as there are other untouched lines with leading tabs as well. Do you want me to change the tabs to spaces in the patch? Is it ok, if I replace all the tabs in the source files? ofproto/ofproto-dpif-sflow.c ofproto/ofproto-dpif-sflow.h There is an additional warning due to line length over 79 characters. I'm going to fix this. Best regards, Zoltan _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
