On Sun, Dec 24, 2017 at 8:02 PM, Ben Pfaff <b...@ovn.org> wrote: > On Sun, Dec 24, 2017 at 02:58:37PM +0100, Matteo Croce wrote: >> Show DPDK version if Open vSwitch is compiled with DPDK support. >> Add a `dpdk_version` column in the datamodel, change ovs-ctl and ovs-dev.py >> to populate the field with the right value. >> >> Signed-off-by: Matteo Croce <mcr...@redhat.com> >> --- >> v2: edit ovs-ctl as well > > Thank you for the update. > > I think that this is likely to cause confusion eventually because it > reports the version of DPDK that ovs-vsctl is linked against. That > doesn't even make sense because the sole reason that ovs-vsctl is linked > against DPDK is to report the version. > > I think it would be more sensible to make ovs-vswitchd set and report > the dpdk version. That can't go wrong in the same way. > > Thanks, > > Ben.
That's true. Initially I tought putting the version info in vswitchd but I didn't want to break anything relying on 'ovs-vswitchd --version' output so I put it in ovs-vsctl as it already contained another field, the DB version. I'm making a v3 with the DPDK version in vswitchd and a safer ovs-ctl/ovs-dev.phy which didn't require the OVS version to be the first line of output. Cheers, -- Matteo Croce per aspera ad upstream _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev