On Tue, Jan 09, 2018 at 08:14:07AM +0800, Ben Pfaff wrote: > On Sat, Jan 06, 2018 at 01:47:54PM +0800, Yi Yang wrote: > > NSH ttl is a 6-bit field ranged from 0 to 63, it should be > > decremented by 1 every hop, if it is 0 or it is so after > > decremented, the packet should be dropped and a packet-in > > message is sent to main controller. > > > > Signed-off-by: Yi Yang <yi.y.y...@intel.com> > > This introduces lots of sparse warnings: > > ../include/openvswitch/nsh.h:314:14: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:14: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:14: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:40: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:40: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:40: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:37: warning: incorrect type in return > expression (different base types) > ../include/openvswitch/nsh.h:314:37: expected restricted ovs_be32 > ../include/openvswitch/nsh.h:314:37: got unsigned int > ../include/openvswitch/nsh.h:327:30: warning: incorrect type in initializer > (different base types) > ../include/openvswitch/nsh.h:327:30: expected restricted ovs_be32 > [usertype] path_hdr > ../include/openvswitch/nsh.h:327:30: got unsigned int > ../include/openvswitch/nsh.h:328:19: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:14: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:14: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:14: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:40: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:40: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:40: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:37: warning: incorrect type in return > expression (different base types) > ../include/openvswitch/nsh.h:314:37: expected restricted ovs_be32 > ../include/openvswitch/nsh.h:314:37: got unsigned int > ../include/openvswitch/nsh.h:334:30: warning: incorrect type in initializer > (different base types) > ../include/openvswitch/nsh.h:334:30: expected restricted ovs_be32 > [usertype] path_hdr > ../include/openvswitch/nsh.h:334:30: got unsigned int > ../include/openvswitch/nsh.h:335:13: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:14: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:14: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:14: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:40: warning: cast to restricted ovs_be32 > ../include/openvswitch/nsh.h:314:40: warning: cast from restricted ovs_be16 > ../include/openvswitch/nsh.h:314:40: warning: restricted ovs_be32 degrades to > integer > ../include/openvswitch/nsh.h:314:37: warning: incorrect type in return > expression (different base types) > ../include/openvswitch/nsh.h:314:37: expected restricted ovs_be32 > ../include/openvswitch/nsh.h:314:37: got unsigned int
They are introduced in patch #2, v8 has fixed them and posted in mailing list, please review new ones, thanks. > > Thanks, > > Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
