> > > > ds_put_format(reply, > > - "\temc hits:%llu\n\tmegaflow hits:%llu\n" > > - "\tavg. subtable lookups per hit:%.2f\n" > > - "\tmiss:%llu\n\tlost:%llu\n" > > + "\tpackets received:%"PRIu64"\n" > > + "\tpacket recirculations:%"PRIu64"\n" > > + "\tavg. datapath passes per packet:%.2f\n" > > + "\temc hits:%"PRIu64"\n" > > + "\tmegaflow hits:%"PRIu64"\n" > > + "\tavg. subtable lookups per megaflow hit:%.2f\n" > > + "\tmiss(i.e. lookup miss with success > > upcall):%"PRIu64"\n" > > + "\tlost(i.e. lookup miss with failed upcall):%"PRIu64"\n" > > [[BO'M]] changing "lookup" to "megaflow" or "dpcls" would be even clearer.
I propose to use "miss with success upcall" and " miss with failed upcall" to simplify further. "Miss" means a complete miss of the datapath lookup. > > > "\tavg. packets per output batch: %.2f\n", > > - stats[DP_STAT_EXACT_HIT], stats[DP_STAT_MASKED_HIT], > > - lookups_per_hit, stats[DP_STAT_MISS], > > stats[DP_STAT_LOST], > > + stats[PMD_STAT_RECV], stats[PMD_STAT_RECIRC], > > + passes_per_pkt, stats[PMD_STAT_EXACT_HIT], > > + stats[PMD_STAT_MASKED_HIT], lookups_per_hit, > > + stats[PMD_STAT_MISS], stats[PMD_STAT_LOST], > > packets_per_batch); > > > [[BO'M]] Avoid the space after the colon in pmd-stat-show output. That stays > consistent with earlier implementation (iirc) and with appctl > dpctl/show -s output. I agree. I also noticed this inconsistency. Regards, Jan _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
