> -----Original Message----- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Friday, January 19, 2018 2:48 PM > To: Stokes, Ian <ian.sto...@intel.com> > Cc: d...@openvswitch.org; Shahaf Shuler <shah...@mellanox.com>; Loftus, > Ciara <ciara.lof...@intel.com>; Thomas Monjalon <tho...@monjalon.net>; > Kevin Traynor <ktray...@redhat.com>; Ilya Maximets > (i.maxim...@samsung.com) <i.maxim...@samsung.com>; Olga Shern > <ol...@mellanox.com> > Subject: Re: [PATCH v3] netdev-dpdk: fix port addition for ports sharing > same PCI id > > On Fri, Jan 19, 2018 at 11:03:52AM +0000, Stokes, Ian wrote: > > > -----Original Message----- > > > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > > > Sent: Wednesday, January 10, 2018 3:05 AM > > > To: d...@openvswitch.org > > > Cc: Stokes, Ian <ian.sto...@intel.com>; Shahaf Shuler > > > <shah...@mellanox.com>; Yuanhan Liu <y...@fridaylinux.org>; Loftus, > > > Ciara <ciara.lof...@intel.com>; Thomas Monjalon > > > <tho...@monjalon.net>; Kevin Traynor <ktray...@redhat.com> > > > Subject: [PATCH v3] netdev-dpdk: fix port addition for ports sharing > > > same PCI id > > > > > > Some NICs have only one PCI address associated with multiple ports. > > > This patch extends the dpdk-devargs option's format to cater for such > devices. > > > > > > To achieve that, this patch uses a new syntax that will be adapted > > > and implemented in future DPDK release (likely, v18.05): > > > http://dpdk.org/ml/archives/dev/2017-December/084234.html > > > > > > And since it's the DPDK duty to parse the (complete and full) syntax > > > and this patch is more likely to serve as an intermediate > > > workaround, here I take a simpler and shorter syntax from it (note > > > it's allowed to have only one category being provided): > > > class=eth,mac=00:11:22:33:44:55:66 > > > > > > Also, old compatibility is kept. Users can still go on with using > > > the PCI id to add a port (if that's enough for them). Meaning, this > > > patch will not break anything. > > > > > > This patch is basically based on the one from Ciara: > > > https://mail.openvswitch.org/pipermail/ovs-dev/2017- > > > October/339496.html > > > > > > Cc: Loftus Ciara <ciara.lof...@intel.com> > > > Cc: Thomas Monjalon <tho...@monjalon.net> > > > Cc: Kevin Traynor <ktray...@redhat.com> > > > Signed-off-by: Yuanhan Liu <y...@fridaylinux.org> > > > > Thanks for the work on this Yuanhan, it's a valuable feature/bug fix. > > > > At this point I think this aligns to the DPDK model? > > Yes, I think so. > > > > > If so, and if there are no other comments on this patchset then I plan > to merge this to DPDK merge over the weekend. > > > > Thank you for taking care of it.
Thanks for all the work on this, I've pushed this to DPDK_MERGE and will also push it to DPDK_MERGE_2_9 for it to be part of the 2.9 release. Ian > > --yliu _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
