On Wed, Dec 06, 2017 at 12:32:39PM +0800, Guoshuai Li wrote: > The structure and function of the group table and meter table are similar, > refactoring code is used to extend for add the meter table. > The following function as lib: table init/destroy/clear, > install contents from desired, remove contents from existing, > Move the contents of desired to existing. > > Signed-off-by: Guoshuai Li <l...@dtdream.com>
Thanks a lot for working on this. I mostly like the new approach. I do have one nontrivial request, which is to remove the use of the callback functions. Usually callback functions make code harder to write and harder to understand because of how they break up code in unnatural ways. In this case, I think that we can just substitute iterator macros, which I generally find easier on all accounts. I posted a 3-patch series that shows the direction that I'm thinking about. The first patch is just your patch #1. The second patch is an example of what I mean about using an iterator instead of a callback function. I only removed the 'create' callback, not the 'remove' callback, but I'd want both to be removed for the final commit. The third patch is just trivia to make the style better match the OVS coding style. The series is here: https://patchwork.ozlabs.org/project/openvswitch/list/?series=25039 Are you willing to revise the series in this direction? Thanks, Ben. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
