> On Jan 25, 2018, at 10:26 AM, Stokes, Ian <ian.sto...@intel.com> wrote:
> 
>> Yes, this was my thinking too.  I don't think we should have a prohibition
>> against using "xxx", but I do usually see it in patches as something that
>> was left behind unintentionally.  That said, my personal preference would
>> be to not have that often in the codebase, since it usually indicates
>> something half-baked, and more often than not, seems to be something no
>> one comes back to address later on.
> 
> I'd agree, I guess there should be a valid explanation as to why it hasn't 
> been implemented in the associated XXX comment. It'll definitely help to 
> raise it as a point of discussion during the review. Sounds good to me.

Great.  Thanks!

--Justin



_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to