On Thu, Feb 01, 2018 at 11:05:35AM -0800, Justin Pettit wrote: > > > On Feb 1, 2018, at 10:59 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > On Tue, Jan 30, 2018 at 03:27:18PM -0800, Justin Pettit wrote: > >> > >>> On Dec 31, 2017, at 9:16 PM, Ben Pfaff <b...@ovn.org> wrote: > >>> > >>> @@ -328,6 +333,7 @@ main(int argc, char *argv[]) > >>> ovs_fatal(0, "%s", error); > >>> } > >>> } > >>> + add_server_db(&server_config); > >> > >> I don't think there's anything that frees 'server_config'. Not a huge > >> deal since it would be on shutdown, but it's always nice to have a > >> clean valgrind run. > > > > server_config is a local variable, and not a pointer. What kind of > > freeing would you like to see? > > I meant the things that were allocated in add_server_db().
OK. I think that these are the same things that are getting allocated in open_db() for "real" databases, so they should be getting freed in the same way. (Maybe there is a memory leak in that case too, but I do not see it yet.) _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev