On Thu, Feb 8, 2018 at 3:18 PM, Ben Pfaff <b...@ovn.org> wrote:
> This removes the requirement of exactly two spaces before the error
> description (now one or more is fine).  It also makes an error message
> clearer.
>
> Signed-off-by: Ben Pfaff <b...@ovn.org>
> ---

Looks good to me.
Acked-by: William Tu <u9012...@gmail.com>

>  build-aux/extract-ofp-errors | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors
> index 71ae0bd5f0ff..6c14f68b883a 100755
> --- a/build-aux/extract-ofp-errors
> +++ b/build-aux/extract-ofp-errors
> @@ -247,7 +247,7 @@ def extract_ofp_errors(fn):
>              expected_errors[m.group(1)] = (fileName, lineNumber)
>              continue
>
> -        m = re.match('((?:.(?!\.  ))+.)\.  (.*)$', comment)
> +        m = re.match('((?:.(?!\.  ))+.)\.\s+(.*)$', comment)
>          if not m:
>              fatal("unexpected syntax between errors")
>
> @@ -257,7 +257,7 @@ def extract_ofp_errors(fn):
>          m = re.match('\s+(?:OFPERR_([A-Z0-9_]+))(\s*=\s*OFPERR_OFS)?,',
>                       line)
>          if not m:
> -            fatal("syntax error expecting enum value")
> +            fatal("syntax error expecting OFPERR_ enum value")
>
>          enum = m.group(1)
>          if enum in names:
> --
> 2.15.1
>
> _______________________________________________
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to