On Tue, May 15, 2018 at 03:48:59AM +0300, Alin Gabriel Serdean wrote: > MSVC complains: > "libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external > symbol pmd_perf_start_iteration referenced in function pmd_thread_main > libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external > symbol pmd_perf_end_iteration referenced in function pmd_thread_main" > > Remove inline keyword from the declaration of: > `pmd_perf_start_iteration` and `pmd_perf_end_iteration` > > More on the subject: > https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/function-inlining-problems > > Fixes: broken build on Windows > > Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org>
It's pretty risky to use "inline" other than as part of "static inline" because of portability problems, even between different versions of the same compiler (GCC changed its own default interpretation from one version to another to comply with C99 rules). The OVS coding style document discourages "inline" in .c files anyway. Acked-by: Ben Pfaff <b...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
