On Fri, May 18, 2018 at 09:29:22AM -0700, Darrell Ball wrote:
> The test 'ofproto-dpif - in place modification (vlan)' fails often
> due to miss handling. Hence, make it more predictable by specifying
> that misses should just be dropped.
> 
> Signed-off-by: Darrell Ball <dlu...@gmail.com>

Thanks for working to make the tests more reliable.

I don't think this part will be effective, because miss_send_len is a
per-OpenFlow connection setting, not a global one:

> +# Always drop misses
> +AT_CHECK([ovs-ofctl -P standard monitor br0 --detach --no-chdir --pidfile])
> +ovs-appctl -t ovs-ofctl ofctl/send 0109000c0123456700000000

This part seems like a good idea:

> +AT_CHECK([ovs-ofctl -O OpenFlow11 mod-table br0 all drop])

Thanks,

Ben.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to