On Mon, May 21, 2018 at 04:44:13PM +0100, Ciara Loftus wrote:
> The vHost PMD brings vHost User port types ('dpdkvhostuser' and
> 'dpdkvhostuserclient') under control of DPDK's librte_ether API, like
> all other DPDK netdev types ('dpdk' and 'dpdkr'). In doing so, direct
> calls to DPDK's librte_vhost library are removed and replaced with
> librte_ether API calls, for which most of the infrastructure is already
> in place.
>
> This change has a number of benefits, including:
> * Reduced codebase (~200LOC removed)
> * More features automatically enabled for vHost ports eg. custom stats
> and additional get_status information.
> * OVS can be ignorant to changes in the librte_vhost API between DPDK
> releases potentially making upgrades easier and the OVS codebase less
> susceptible to change.
>
> The sum of all DPDK port types must not exceed RTE_MAX_ETHPORTS which is
> set and can be modified in the DPDK configuration. Prior to this patch
> this only applied to 'dpdk' and 'dpdkr' ports, but now applies to all
> DPDK port types including vHost User.
>
> Performance (pps) of the different topologies p2p, pvp, pvvp and vv has
> been measured to remain within a +/- 5% margin of existing performance.
Thanks for putting this together.
I think when this idea was discussed at least in my head we would
pretty much kill any vhost specific info and use a standard eth API
instead. However, it doesn't look like to be case, we still have the
mtu and queue issues, special construct/destruct, send, and etc which
IMHO defeats the initial goal.
Leaving that aside for a moment, I wonder about imposed limitations
if we switch to the eth API too. I mean, things that we can do today
because OVS is managing vhost that we won't be able after the API
switch.
Thanks,
fbl
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
