> > On May 24, 2018, at 10:32 AM, Ben Pfaff <b...@ovn.org> wrote: > > > > Several OVS structs contain embedded named unions, like this: > > > > struct { > > ... > > union { > > ... > > } u; > > }; > > > > C11 standardized a feature that many compilers already implemented > > anyway, where an embedded union may be unnamed, like this: > > > > struct { > > ... > > union { > > ... > > }; > > }; > > > > This is more convenient because it allows the programmer to omit "u." > > in many places. OVS already used this feature in several places. > > This commit embraces it in several others. > > > > Signed-off-by: Ben Pfaff <b...@ovn.org> > > I didn't read through it carefully, but I support the change, and it's the sort of > thing that normally breaks in obvious ways. > > Acked-by: Justin Pettit <jpet...@ovn.org> > > --Justin > > FYI I compiled on MSVC and ran the unit test and it was fine.
Tested-by: Alin Gabriel Serdean <aserd...@ovn.org> Acked-by: Alin Gabriel Serdean <aserd...@ovn.org> _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev