On Fri, Jun 15, 2018 at 1:21 PM, Gregory Rose <gvrose8...@gmail.com> wrote: > On 6/15/2018 1:05 PM, Ben Pfaff wrote: >> >> On Tue, May 29, 2018 at 06:06:19PM +0000, Neal Shrader via dev wrote: >>> >>> While investigating a kernel panic, our team noticed that UDP traffic >>> recieved by an STT tunnel will always have a gso_type set as SKB_GSO_UDP. >>> After decap, we also noticed that traffic that had this flag set had its >>> fragmentation type set as OVS_FRAG_TYPE_FIRST during key extraction. >>> >>> When the connection tracker encounters this, it assumes it's already >>> dealing with fragmented traffic, which might not be the case. This >>> patch simply ensures we're dealing with an actual fragment before sending >>> the skb off to be reassembled. >>> >>> Reported-by: Johannes Erdfelt <johan...@erdfelt.com> >>> Reported-at: >>> https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046800.html >>> Signed-off-by: Neal Shrader <n...@digitalocean.com> >> >> Thanks a lot for the patch. >> >> Greg, have you taken a look at this? > > > I had it flagged for review but have not yet had a chance to get to it. > I'll do so now. >
I do not think this is right approach to fix the issue. I have posted my comment on discuss mailing thread: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-May/046800.html _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
