Thanks! I will improve the patch based on the suggestions and will post it soon.
-Qiuyu On Tue, Jul 3, 2018 at 1:00 PM, Ben Pfaff <[email protected]> wrote: > On Wed, Jun 27, 2018 at 10:58:42AM -0700, Qiuyu Xiao wrote: >> From: Ansis Atteka <[email protected]> >> >> This patch reintroduces ovs-monitor-ipsec daemon that >> was previously removed by commit 2b02d770 ("openvswitch: >> Allow external IPsec tunnel management.") >> >> The reason for removal at the time was that there were IPsec >> flavoured tunnel types, like ipsec_gre, that consumed for >> themselves the least significant bit of SKB mark irrelevant >> whether Open vSwitch users were using IPsec or not. >> >> After this patch, there are no IPsec flavored tunnels anymore. >> IPsec is enabled by setting up the right values in: >> 1. OVSDB:Interface:options column; >> 2. OVSDB:Open_vSwitch:other_config column; >> 3. OpenFlow pipeline. >> >> Signed-off-by: Ansis Atteka <[email protected]> > > Thanks for working on this. > > You should add your own Signed-off-by line just after Ansis's. > > Aaron gave some helpful comments. I hope you will consider them. > > The documentation has some odd <p>...</p> paragraphs in it. Do you > think that there is missing documentation? Maybe they can just be > deleted. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
