On 7/12/2018 10:55 PM, Ben Pfaff wrote:
uint8_t values shouldn't be passed to ntohs().
Found by soarse.
Signed-off-by: Ben Pfaff <[email protected]>
---
lib/netdev-dpdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index bb4d60f26cc4..b4ed4ad5919c 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -4202,8 +4202,8 @@ dump_flow_pattern(struct rte_flow_item *item)
VLOG_DBG("rte flow icmp pattern:\n");
if (icmp_spec) {
VLOG_DBG(" Spec: icmp_type=%"PRIu8", icmp_code=%"PRIu8"\n",
- ntohs(icmp_spec->hdr.icmp_type),
- ntohs(icmp_spec->hdr.icmp_code));
+ icmp_spec->hdr.icmp_type,
+ icmp_spec->hdr.icmp_code);
} else {
VLOG_DBG(" Spec = null\n");
}
Thanks Ben, will add this to the next pull request.
Thanks
Ian
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
