> On Jul 16, 2018, at 4:39 PM, Darrell Ball <dlu...@gmail.com> wrote:
> diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h
> index bd6234d..6eb55b4 100644
> --- a/lib/ct-dpif.h
> +++ b/lib/ct-dpif.h
> @@ -17,6 +17,7 @@
> #ifndef CT_DPIF_H
> #define CT_DPIF_H
>
> +#include "ipf.h"
I don't think it's necessary to add this header file.
> diff --git a/lib/dpctl.man b/lib/dpctl.man
> index a1eb026..a75fc77 100644
> --- a/lib/dpctl.man
> +++ b/lib/dpctl.man
> @@ -287,3 +287,12 @@ after conntrack. Both v4 and v6 are enabled by default.
> Disables fragmentation handling for the userspace datapath connection
> tracker. Either \fBv4\fR or \fBv6\fR must be specified. Both v4 and v6 are
> enabled by default.
> +.
> +.TP
> +\*(DX\fBipf\-set\-min\-frag\fR [\fIdp\fR] \fBv4\fR|\fBv6\fR \fIminfrag\fR
> +Sets the minimum fragment size, which applies to non-last fragments,
> +supported by the userspace datapath connection tracker. Either v4 or v6
> +must be specified. The default v4 value is 1200 and the clamped minimum is
> +400. The default v6 value is 1280, with a clamped minimum of 400, for
> +testing flexibility. The maximum frag size is not clamped, however setting
> +this value too high might result in valid fragments being dropped.
Why would someone configure this value? Is it just for debugging? If it's for
debugging, I wonder how generally useful it is.
In any case, assuming we apply this patch, I'd like to apply the incremental at
the bottom of this message.
--Justin
-=-=-=-=-=-=-=-=-
diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h
index 6eb55b4b0197..f8a31921e16a 100644
--- a/lib/ct-dpif.h
+++ b/lib/ct-dpif.h
@@ -17,7 +17,6 @@
#ifndef CT_DPIF_H
#define CT_DPIF_H
-#include "ipf.h"
#include "openvswitch/types.h"
#include "packets.h"
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 9fc205a2181a..5fe0ea1c3229 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -1756,7 +1756,7 @@ dpctl_ipf_set_min_frag(int argc, const char *argv[],
} else {
error = EINVAL;
dpctl_error(dpctl_p, error,
- "parameter missing: v4 for ipv4 or v6 for ipv6");
+ "parameter missing: 'v4' for IPv4 or 'v6' for IPv6");
}
dpif_close(dpif);
}
diff --git a/lib/dpctl.man b/lib/dpctl.man
index 9cac158a69d8..82be828b987b 100644
--- a/lib/dpctl.man
+++ b/lib/dpctl.man
@@ -284,9 +284,10 @@ supported for userspace datapath.
.
.TP
\*(DX\fBipf\-set\-min\-frag\fR [\fIdp\fR] \fBv4\fR|\fBv6\fR \fIminfrag\fR
-Sets the minimum fragment size, which applies to non-last fragments,
-supported by the userspace datapath connection tracker. Either v4 or v6
-must be specified. The default v4 value is 1200 and the clamped minimum is
-400. The default v6 value is 1280, with a clamped minimum of 400, for
-testing flexibility. The maximum frag size is not clamped, however setting
-this value too high might result in valid fragments being dropped.
+Sets the minimum fragment size for non-final fragments to
+\fI\fIminfrag\fR. Either \fBv4\fR or \fBv6\fR must be specified. The
+default IPv4 value is 1200 and the clamped minimum is 400. The default
+IPv6 value is 1280, with a clamped minimum of 400, for testing
+flexibility. The maximum fragment size is not clamped, however, setting
+this value too high might result in valid fragments being dropped. Only
+supported for userspace datapath.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
