On Mon, Jul 30, 2018 at 8:12 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > > On Jul 30, 2018, at 5:58 PM, Justin Pettit <jpet...@ovn.org> wrote: > > > > Thanks for the review! I've pushed this series to master. > > I also just pushed this to branch-2.10. > > The rate-limiting is implemented using meters. Unfortunately, there's a bug in the current kernels that prevents meters from working properly. I've sent a patch to upstream Linux, which should solve the problem: > > https://marc.info/?l=linux-netdev&m=153281677212826&w=2 > > Once that is merged, I'll commit it to OVS, and it should work with both Linux and userspace datapaths. > > --Justin > > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Thanks Justin for the great work!! Sorry that I didn't get time to review the series, just some quick questions regarding the kernel bug you mentioned. - What's the impact of having meter ID = 0? Does it mean the meters and ACL rate limit feature can't be used at all, or is it just some limitations in certain scenarios? - For the bug fix, can we get it reviewed (and probably merged) in datapath/compact first here in the OVS community without having to wait for kernel upstream? What's the usual practice for kernel module patches? Thanks, Han _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
