Markos Chandras <mchand...@suse.de> writes: > On 28/08/18 12:57, 0-day Robot wrote: >> Bleep bloop. Greetings Markos Chandras, I am a robot and I have >> tried out your patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >> ERROR: Author Markos Chandras <mchand...@suse.de> needs to sign off. >> Lines checked: 25, Warnings: 0, Errors: 1 >> >> > > But it is signed off :) > > I guess the script may have been confused by the '---' I used to quote > the OBS warning.
Yes - actually, even git mailinfo gets confused by it: 09:16:48 aconole /tmp$ git mailinfo msg ptch < ovs-dev-utilities-Drop-shebang-from-bash-completion-script.patch Author: Markos Chandras Email: mchand...@suse.de Subject: utilities: Drop shebang from bash completion script Date: Tue, 28 Aug 2018 12:21:24 +0100 09:17:03 aconole /tmp$ cat msg This fixes the following warning when building Open vSwitch on the openSUSE Build Service: 09:17:07 aconole /tmp$ In the future, it's best to indent the lines you intend to be quoting. Patchwork will process the patch slightly more liberally than git-mailinfo, but if I use git-am to apply your mbox file, the message gets truncated and the commit log only shows the same as the above 'msg' file from git mailinfo. I think it can be fixed when applying, though (by making the change I've outlined above). _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
