----- Original Message ----- > From: "Tiago Lam" <tiago....@intel.com> > To: "Bala Sankaran" <bsank...@redhat.com>, d...@openvswitch.org > Cc: "Aaron Conole" <acon...@redhat.com>, "Ian Stokes" <ian.sto...@intel.com>, > "Ciara Loftus" <ciara.lof...@intel.com> > Sent: Tuesday, 4 September, 2018 6:32:39 AM > Subject: Re: [PATCH v4 6/6] system-dpdk: Connect network namespaces via > dpdkvhostuser ports > > On 31/08/2018 16:55, Bala Sankaran wrote: > > This adds a few unit tests to the 'check-dpdk' subsystem that will > > exercise allocations of two network namespaces, PMDs, and the > > vhost-user and vhost-user-client code path(separate tests). > > As part of the tests, userspace bridge is added and attached to OVS. > > Also, the tap devices created are added to the network namespaces. > > > > The ultimatum is to connect the two network namespaces by pinging them. > > > > Signed-off-by: Bala Sankaran <bsank...@redhat.com> > > Co-authored-by: Aaron Conole <acon...@redhat.com> > > Signed-off-by: Aaron Conole <acon...@redhat.com> > > --- > > Hi Bala, > > Thanks for the new version and including the vhostuserclient test - that > test runs OK on my end, and passes successfully (just a note below). > > As I mentioned on v3, I've faced some issues getting the vhostuser test > to run on my system. I've tried testpmd binaries compiled against DPDK > 18.02, 18.05, 18.08 and 18.11-rc0. Only 18.02 seemed to work. > > After spending some time bisecting this, it comes down to the > "--socket-mem" option, and providing some memory for all available > sockets in the system [1]. If one provides "--socket-mem=512" (like > you're doing on the tests below), pre DPDK 18.05, testpmd would fail > with an error mentioning it can't allocate memory for a socket 1 (if > your system has 2 sockets). Post DPDK 18.05, it goes on and doesn't > complain, but in my case it also fails to forward traffic. > > So, this begs the question, does the first test pass for you as is, > without a second argument to "--socket-mem"? How many sockets does your > system have?
Hello Tiago, I've got 4 sockets in the VM that I tested on. I have been using the --socket-mem=512 as an argument for testpmd each time I test, I don't reckon that my tests would work without the argument. Best, Bala. > > [1] Note that all ports are allocated, in my system, in socket 0. But > still, I have to allocate as little as "1" to get traffic through. > > > tests/system-dpdk.at | 152 > > ++++++++++++++++++++++++++++++++++++++++++++++++++- > > 1 file changed, 151 insertions(+), 1 deletion(-) > > > > diff --git a/tests/system-dpdk.at b/tests/system-dpdk.at > > index 58dc8aa..baa74da 100644 > > --- a/tests/system-dpdk.at > > +++ b/tests/system-dpdk.at > > @@ -1,7 +1,10 @@ > > +m4_define([CONFIGURE_VETH_OFFLOADS], > > + [AT_CHECK([ethtool -K $1 tx off], [0], [ignore], [ignore])]) > > + > > AT_BANNER([OVS-DPDK unit tests]) > > > > dnl > > -------------------------------------------------------------------------- > > -dnl Check if EAL init is successfull > > +dnl Check if EAL init is successful > > AT_SETUP([OVS-DPDK datapath - EAL init]) > > AT_KEYWORDS([dpdk]) > > OVS_DPDK_PRE_CHECK() > > @@ -74,3 +77,150 @@ OVS_VSWITCHD_STOP(["\@does not exist. The Open vSwitch > > kernel module is probably > > \@EAL: No free hugepages reported in hugepages-1048576kB@d"]) > > AT_CLEANUP > > dnl > > -------------------------------------------------------------------------- > > + > > + > > + > > +dnl > > -------------------------------------------------------------------------- > > +dnl Ping vhost-user port > > +AT_SETUP([OVS-DPDK datapath - ping vhost-user ports]) > > +AT_KEYWORDS([dpdk]) > > +OVS_DPDK_PRE_CHECK() > > +AT_SKIP_IF([! which testpmd >/dev/null 2>/dev/null]) > > +OVS_DPDK_START() > > + > > +dnl Add userspace bridge and attach it to OVS > > +AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev]) > > +AT_CHECK([ovs-vsctl add-port br10 dpdkvhostuser0 -- set Interface > > dpdkvhostuser0 \ > > + type=dpdkvhostuser], [], > > + [stdout], [stderr]) > > +AT_CHECK([ovs-vsctl show], [], [stdout]) > > + > > +dnl Parse log file > > +AT_CHECK([grep "VHOST_CONFIG: vhost-user server: socket created" \ > > + ovs-vswitchd.log], [], [stdout]) > > +AT_CHECK([grep "Socket $OVS_RUNDIR/dpdkvhostuser0 created for vhost-user > > port dpdkvhostuser0" \ > > + ovs-vswitchd.log], [], [stdout]) > > +AT_CHECK([grep "VHOST_CONFIG: bind to $OVS_RUNDIR/dpdkvhostuser0" > > ovs-vswitchd.log], [], > > + [stdout]) > > + > > +dnl Set up namespaces > > +ADD_NAMESPACES(ns1, ns2) > > + > > +dnl Add veth device > > +ADD_VETH(tap1, ns2, br10, "172.31.110.12/24") > > + > > +dnl Execute testpmd in background > > +on_exit "pkill -f -x -9 'tail -f /dev/null'" > > +tail -f /dev/null | testpmd --socket-mem=512 \ > > + --vdev="net_virtio_user,path=$OVS_RUNDIR/dpdkvhostuser0" \ > > + --vdev="net_tap0,iface=tap0" --file-prefix page0 \ > > + --single-file-segments -- -a > > >$OVS_RUNDIR/testpmd-dpdkvhostuser0.log 2>&1 & > > Since this test doesn't require any physical devices, I would use either > the "--no-pci" option or check if any physical devices is bound to DPDK > any skip the test if so. Otherwise DPDK will try to init the driver > there and testpmd will hang as a consequence. Same for the other test below. > > Tiago. > > > + > > +dnl Give settling time to the testpmd processes - NOTE: this is bad form. > > +sleep 10 > > + > > +dnl Move the tap devices to the namespaces > > +AT_CHECK([ps aux | grep testpmd], [], [stdout], [stderr]) > > +AT_CHECK([ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip link set tap0 netns ns1], [], [stdout], [stderr]) > > + > > +AT_CHECK([ip netns exec ns1 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ip link show | grep tap0], [], [stdout], > > [stderr]) > > +AT_CHECK([ip netns exec ns1 ip link set tap0 up], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ip addr add 172.31.110.11/24 dev tap0], [], > > + [stdout], [stderr]) > > + > > +AT_CHECK([ip netns exec ns1 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns2 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ping -c 4 -I tap0 172.31.110.12], [], > > [stdout], > > + [stderr]) > > + > > +dnl Clean up the testpmd now > > +pkill -f -x -9 'tail -f /dev/null' > > + > > +dnl Clean up > > +AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuser0], [], [stdout], [stderr]) > > +OVS_VSWITCHD_STOP(["\@does not exist. The Open vSwitch kernel module is > > probably not loaded.@d > > +\@Failed to enable flow control@d > > +\@VHOST_CONFIG: recvmsg failed@d > > +\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostuser0: No such > > file or directory@d > > +\@Global register is changed during@d > > +\@dpdkvhostuser ports are considered deprecated; please migrate to > > dpdkvhostuserclient ports.@d > > +\@failed to enumerate system datapaths: No such file or directory@d > > +\@EAL: Invalid NUMA socket, default to 0@d > > +\@EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using > > unreliable clock cycles !@d > > +\@EAL: No free hugepages reported in hugepages-1048576kB@d"]) > > +AT_CLEANUP > > +dnl > > -------------------------------------------------------------------------- > > + > > +dnl > > -------------------------------------------------------------------------- > > +dnl Ping vhost-user-client port > > +AT_SETUP([OVS-DPDK datapath - ping vhost-user-client ports]) > > +AT_KEYWORDS([dpdk]) > > +OVS_DPDK_PRE_CHECK() > > +AT_SKIP_IF([! which testpmd >/dev/null 2>/dev/null]) > > +OVS_DPDK_START() > > + > > +dnl Add userspace bridge and attach it to OVS > > +AT_CHECK([ovs-vsctl add-br br10 -- set bridge br10 datapath_type=netdev]) > > +AT_CHECK([ovs-vsctl add-port br10 dpdkvhostuserclient0 -- set Interface \ > > + dpdkvhostuserclient0 \ > > + type=dpdkvhostuserclient \ > > + options:vhost-server-path=$OVS_RUNDIR/dpdkvhostclient0], [], > > + [stdout], [stderr]) > > +AT_CHECK([ovs-vsctl show], [], [stdout]) > > + > > +dnl Parse log file > > +AT_CHECK([grep "VHOST_CONFIG: vhost-user client: socket created" > > ovs-vswitchd.log], [], [stdout]) > > +AT_CHECK([grep "vHost User device 'dpdkvhostuserclient0' created in > > 'client' mode, using client socket" ovs-vswitchd.log], [], [stdout]) > > +AT_CHECK([grep "VHOST_CONFIG: $OVS_RUNDIR/dpdkvhostclient0: > > reconnecting..." ovs-vswitchd.log], [], [stdout]) > > + > > +dnl Set up namespaces > > +ADD_NAMESPACES(ns1, ns2) > > + > > +dnl Add veth device > > +ADD_VETH(tap1, ns2, br10, "172.31.110.12/24") > > + > > +dnl Execute testpmd in background > > +on_exit "pkill -f -x -9 'tail -f /dev/null'" > > +tail -f /dev/null | testpmd --socket-mem=512 \ > > + > > --vdev="net_virtio_user,path=$OVS_RUNDIR/dpdkvhostclient0,server=1" > > \ > > + --vdev="net_tap0,iface=tap0" --file-prefix page0 \ > > + --single-file-segments -- -a > > >$OVS_RUNDIR/testpmd-dpdkvhostuserclient0.log 2>&1 & > > + > > +dnl Give settling time to the testpmd processes - NOTE: this is bad form. > > +sleep 10 > > + > > +dnl Move the tap devices to the namespaces > > +AT_CHECK([ps aux | grep testpmd], [], [stdout], [stderr]) > > +AT_CHECK([ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip link set tap0 netns ns1], [], [stdout], [stderr]) > > + > > +AT_CHECK([ip netns exec ns1 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ip link show | grep tap0], [], [stdout], > > [stderr]) > > +AT_CHECK([ip netns exec ns1 ip link set tap0 up], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ip addr add 172.31.110.11/24 dev tap0], [], > > + [stdout], [stderr]) > > + > > +AT_CHECK([ip netns exec ns1 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns2 ip link show], [], [stdout], [stderr]) > > +AT_CHECK([ip netns exec ns1 ping -c 4 -I tap0 172.31.110.12], [], > > [stdout], > > + [stderr]) > > + > > +dnl Clean up the testpmd now > > +pkill -f -x -9 'tail -f /dev/null' > > + > > +dnl Clean up > > +AT_CHECK([ovs-vsctl del-port br10 dpdkvhostuserclient0], [], [stdout], > > [stderr]) > > +OVS_VSWITCHD_STOP(["\@does not exist. The Open vSwitch kernel module is > > probably not loaded.@d > > +\@Failed to enable flow control@d > > +\@VHOST_CONFIG: recvmsg failed@d > > +\@VHOST_CONFIG: failed to connect to $OVS_RUNDIR/dpdkvhostclient0: No such > > file or directory@d > > +\@Global register is changed during@d > > +\@dpdkvhostuser ports are considered deprecated; please migrate to > > dpdkvhostuserclient ports.@d > > +\@failed to enumerate system datapaths: No such file or directory@d > > +\@EAL: Invalid NUMA socket, default to 0@d > > +\@EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using > > unreliable clock cycles !@d > > +\@EAL: No free hugepages reported in hugepages-1048576kB@d"]) > > +AT_CLEANUP > > +dnl > > -------------------------------------------------------------------------- > > > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
