0-day Robot <ro...@bytheb.org> writes:

> Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your 
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> build:
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H 
> -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes 
> -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security 
> -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align 
> -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes 
> -Wmissing-field-initializers -fno-strict-aliasing -Wshadow 
> -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT 
> ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF 
> ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c -o 
> ofproto/ofproto_libofproto_la-ofproto.lo `test -f 'ofproto/ofproto.c' || echo 
> './'`ofproto/ofproto.c
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I 
> ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra 
> -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum 
> -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes 
> -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers 
> -fno-strict-aliasing -Wshadow -Wno-null-pointer-arithmetic -Werror -Werror -g 
> -O2 -MT ofproto/ofproto_libofproto_la-ofproto.lo -MD -MP -MF 
> ofproto/.deps/ofproto_libofproto_la-ofproto.Tpo -c ofproto/ofproto.c -o 
> ofproto/ofproto_libofproto_la-ofproto.o
> ofproto/ofproto.c: In function 'ofproto_group_mod_finish':
> ofproto/ofproto.c:7400:13: error: missing initializer for field 'new_buckets' 
> of 'struct <anonymous>' [-Werror=missing-field-initializers]
>              .new_buckets = new_group ? &new_group->buckets : NULL,
>              ^
> In file included from ofproto/ofproto.c:48:0:
> ./include/openvswitch/ofp-monitor.h:135:36: note: 'new_buckets' declared here
>              const struct ovs_list *new_buckets;
>                                     ^
> ofproto/ofproto.c:7401:13: error: missing initializer for field 
> 'group_existed' of 'struct <anonymous>' [-Werror=missing-field-initializers]
>              .group_existed = group_collection_n(&ogm->old_groups) > 0,
>              ^
> In file included from ofproto/ofproto.c:48:0:
> ./include/openvswitch/ofp-monitor.h:140:17: note: 'group_existed' declared 
> here
>              int group_existed;
>                  ^
> ofproto/ofproto.c: At top level:
> cc1: error: unrecognized command line option "-Wno-null-pointer-arithmetic" 
> [-Werror]
> cc1: all warnings being treated as errors
> make[2]: *** [ofproto/ofproto_libofproto_la-ofproto.lo] Error 1
> make[2]: Leaving directory 
> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory 
> `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
>
>
> Please check this out.  If you feel there has been an error, please email 
> acon...@bytheb.org
>
> Thanks,
> 0-day Robot

I think the issue here on the bot side is that the compiler is not able
to deal with this initialization semantic.  I'll follow up and get it
fixed.

Meanwhile, I've disabled the --enable-Werror, and I'll work on pulling
out the warnings that are 'new' vs. 'not-new'.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to