On Tue, Oct 30, 2018 at 01:10:51PM +0000, Stokes, Ian wrote: > > > Report the link speed of the device in netdev_dpdk_get_status() > > > function. > > > > > > Link speed is already reported as part of the netdev_get_features() > > > function. However only link speeds defined in the OpenFlow specs are > > > supported so speeds such as 25 Gbps etc. are not shown. The link speed > > > for the device is available in Mbps in rte_eth_link. > > > This commit converts the link speed for a given dpdk device to an easy > > > to read string and reports it in get_status(). [...] > > Anyway, you don't need to snprintf the constant strings. You may just > > return them like netdev_feature_to_name() does. > Sure that looks a bit more concise. I could use that for the v2.
That sounds reasonable, otherwise both patches look good to me. Thanks, fbl _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
