On Mon, Nov 05, 2018 at 06:17:54PM +0100, Lorenzo Bianconi wrote: > > > > Thanks for the patch. > > Hi Ben, > > thx for the review. Few comments inline. > > Regards, > Lorenzo > > > > > I'm not sure in what circumstances a broadcast domain would be shared > > among deployments. I tend to think of OVN L2 networks as contained. > > But I guess this patch was written for a reason, so it must be common > > enough. > > > > I can see at least two possible routes here: > > > > - The current one, in which there is a default MAC_ADDR_PREFIX. Two > > OVN deployments cannot coexist using MACAM, supposing they somehow > > share a broadcast domain, unless at least one of them manually > > selects an alternate MAC prefix. This may be desirable if it is > > important that the default MAC prefix 0A-00-00 be recognizable. > > > > I preferred to maintain a default mac prefix for compatibility with > older deployments > that maybe assume to have a default mac prefix for MACAM, but if you > prefer we can > switch to the second implementation > > > - An alternative would be for every OVN deployment to automatically > > select a random MAC address prefix. When ovn-northd starts, it > > would read the MAC address prefix out of NB_Global, and if there > > isn't one, generate one randomly and store it into NB_Global. > > Then there would be fewer pitfalls in setting up multiple > > deployments. > > > > the only concern that come to my mind is that, is possible to have a > mac prefix collision on multiple > deployments when mac prefix is randomly chosen?
Yes, of course, it's a 22-bit space, collisions can happen. It sounds like we should stick with the proposed approach, but I'll give this a little while for others to comment. _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
