> On 12.11.2018 12:26, Eelco Chaudron wrote:
> > When the netdev link flags are changed, !NETDEV_UP, the DPDK ports are
> > not actually going down. This is causing problems for people trying to
> > bring down a bond member. The bond link is no longer being used to
> > receive or transmit traffic, however, the other end keeps sending data
> > as the link remains up.
> >
> > With OVS 2.6 the link was brought down, and this was changed with
> > commit 3b1fb0779. In this commit, it's explicitly mentioned that the
> > link down/up DPDK APIs are not called as not all PMD devices support it.
> >
> > However, this patch does call the appropriate DPDK APIs and ignoring
> > errors due to the PMD not supporting it. PMDs not supporting this
> > should be fixed in DPDK upstream.
> >
> > I verified this patch is working correctly using the ovs-appctl
> > netdev-dpdk/set-admin-state <port> {up|down} and ovs-ofctl mod-port
> > <bridge> <port> {up|down} commands on a XL710 and 82599ES.
> >
> > Fixes: 3b1fb0779b87 ("netdev-dpdk: Don't call rte_dev_stop() in
> > update_flags().")
> > Signed-off-by: Eelco Chaudron <echau...@redhat.com>
> >
> > ---
> >
> > * V5:
> > - Added error message for link change failure case
> >
> > * V4:
> > - Use netdev_get_name() instead of dev->up.name directly
> >
> > * V3:
> > - Update log message and changed the level to INFO
> >
> > * V2:
> > - Only call link state change function if the upstate changed
> > - Restore original flags on error
> > - Log a message when the NIC does not support the link state API
> >
> > lib/netdev-dpdk.c | 20 ++++++++++++++++++++
> > 1 file changed, 20 insertions(+)
> >
>
> Acked-by: Ilya Maximets <i.maxim...@samsung.com>
Thanks all, I've pushed this to master and backported from 2.10 -> 2.7.
Thanks
Ian
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
