On 1/21/2019 2:06 PM, Gregory Rose wrote:
It turns out after I had more of a chance to look at this that
HAVE_INET_FRAGS_WITH_FRAGS_WORK and
HAVE_INET_FRAGS_RND are both keying off the same upstream patch I
mentioned in the commit message
(648700f76b03). There's no need for the redundancy. Nice catch!
I'm going to fix this by getting rid of
HAVE_INET_FRAGS_WITH_FRAGS_WORK because that is sort of
unwieldy and only used in a few spots. We can simplify acinclude.m4 a
bit and work with a single define
for the compilation switch.
A v2 patch will be forthcoming. Thanks for the review!
I take that back. If you go far enough back (3.16.1) then you see that
the frags_work field is added
independently of the rnd field in the inet_frags structure.
It is correct to separately check for frags_work and rnd as done in this
patch because there are times when one
field will be defined but not the other. It is true that upstream
commit 648700f76b03 removed the frags_work
and rnd fields at the same time but they were introduced separately and
require discrete compilation flags.
If there are no other objections can I please get an ack?
Thanks,
- Greg
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
