On Wed, Jan 23, 2019 at 4:14 PM Alin Gabriel Serdean <aserd...@ovn.org> wrote:
> The test fails on Windows because of: > <--cut--> > ovn-nbctl: sw0: invalid network address: 2001;1\64 > ovn-nbctl: sw1: invalid network address: 2002;1\64 > <--cut--> > > This is due to the fact msys converts '::1' into ';1'. > > Use IPv6 long form instead of its short variant. > > Signed-off-by: Alin Gabriel Serdean <aserd...@ovn.org> > Acked-by: Numan Siddique <nusid...@redhat.com> We generally tend to use the short form and we don't even realize it breaks windows. Probably checkpatch can check it and flag an error. I will give it a try to add this check in checkpatch utility. Thanks Numan > --- > tests/ovn.at | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/ovn.at b/tests/ovn.at > index 5f387fc07..f54f24c74 100644 > --- a/tests/ovn.at > +++ b/tests/ovn.at > @@ -11858,12 +11858,12 @@ ovn-nbctl create Logical_Router name=lr0 > options:chassis=hv1 > ovn-nbctl ls-add sw0 > ovn-nbctl ls-add sw1 > > -ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24 2001::1/64 > +ovn-nbctl lrp-add lr0 sw0 00:00:01:01:02:03 192.168.1.1/24 > 2001:0:0:0:0:0:0:1/64 > ovn-nbctl lsp-add sw0 rp-sw0 -- set Logical_Switch_Port rp-sw0 \ > type=router options:router-port=sw0 \ > -- lsp-set-addresses rp-sw0 router > > -ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24 2002::1/64 > +ovn-nbctl lrp-add lr0 sw1 00:00:02:01:02:03 172.16.1.1/24 > 2002:0:0:0:0:0:0:1/64 > ovn-nbctl lsp-add sw1 rp-sw1 -- set Logical_Switch_Port rp-sw1 \ > type=router options:router-port=sw1 \ > -- lsp-set-addresses rp-sw1 router > -- > 2.16.1.windows.1 > > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
