Hyong Youb Kim via dev <ovs-dev@openvswitch.org> writes: > Run ovs-tcpdump with --span, and it throws the following > exception. Define mirror_select_all to avoid the error. > > Traceback (most recent call last): > File "/usr/local/bin/ovs-tcpdump", line 488, in <module> > main() > File "/usr/local/bin/ovs-tcpdump", line 454, in main > mirror_select_all) > UnboundLocalError: local variable 'mirror_select_all' referenced before > assignment > > Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.") > > Signed-off-by: Hyong Youb Kim <hyon...@cisco.com> > ---
Hi Hyong, Thanks for the patch. The email address on this looks like it's coming from the list, rather than you. Please look at your git email configuration, and make sure you are sending correctly, with a proper From:, To:, and mail-server configuration. See also: https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_project_over_email https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/ > utilities/ovs-tcpdump.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in > index 22f249f58..269c252f8 100755 > --- a/utilities/ovs-tcpdump.in > +++ b/utilities/ovs-tcpdump.in > @@ -379,6 +379,7 @@ def main(): > > skip_next = False > mirror_interface = None > + mirror_select_all = False > dump_cmd = 'tcpdump' > > for cur, nxt in argv_tuples(sys.argv[1:]): _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev