Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch. Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 110 characters long (recommended limit is 79) ERROR: C99 style comment #171 FILE: ovsdb/monitor.c:463: //VLOG_WARN("dbmon %p, cond_add_column: %s, n_columns %"PRIuSIZE, dbmon, columns[i]->name, n_columns); WARNING: Line is 117 characters long (recommended limit is 79) ERROR: C99 style comment #187 FILE: ovsdb/monitor.c:538: //VLOG_WARN("untrack change: %"PRIu64", found changes %p, n_refs %d", transaction, changes, changes->n_refs); WARNING: Line is 123 characters long (recommended limit is 79) ERROR: C99 style comment #189 FILE: ovsdb/monitor.c:540: //VLOG_WARN("untrack change: %"PRIu64", destroy changes %p, n_refs %d", transaction, changes, changes->n_refs); WARNING: Line is 119 characters long (recommended limit is 79) ERROR: C99 style comment #197 FILE: ovsdb/monitor.c:558: //VLOG_WARN("track new change: %"PRIu64", found changes %p, n_refs %d", transaction, changes, changes->n_refs); ERROR: C99 style comment #200 FILE: ovsdb/monitor.c:561: //VLOG_WARN("track new change: %"PRIu64, transaction); ERROR: C99 style comment #342 FILE: ovsdb/monitor.c:1617: //VLOG_WARN("monitor commit: m_transactions: %"PRIu64, m->n_transactions); Lines checked: 425, Warnings: 4, Errors: 6 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev