Ophir Munk <[email protected]> writes: > Hi Aaron, > 1. I am the committer of this patch.
There is a corner case that isn't currently handled (because it isn't common). Developer A authors a change. Signed-off-by is needed. Sends to Developer B Developer B takes that change, with no intervention. Developer B needs to sign off as part of the delivery change, but must not add a Co-authored-by (since no code was authored by Developer B). checkpatch blows up in this case. But it isn't common, and I wouldn't see it as a "gate" (if it makes sense). > 2. When running latest checkpatch in my environment I do not get such warning > indication. Correct - it won't flag you because it allows for one extra signed-off-by tag. > Can you please explain about what the Robot is complaining? Just a difficult to handle corner case. > Regards, > Ophir > >> -----Original Message----- >> From: 0-day Robot <[email protected]> >> Sent: Monday, February 18, 2019 7:42 PM >> To: Ophir Munk <[email protected]> >> Cc: [email protected] >> Subject: Re: netdev-dpdk: Move offloading-code to a new file >> >> Bleep bloop. Greetings Ophir Munk, I am a robot and I have tried out your >> patch. >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >> WARNING: Unexpected sign-offs from developers who are not authors or >> co-authors or committers: Ophir Munk <[email protected]> Lines >> checked: 1652, Warnings: 1, Errors: 0 >> >> >> Please check this out. If you feel there has been an error, please email >> [email protected] >> >> Thanks, >> 0-day Robot _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
