On Wed, Feb 20, 2019 at 04:47:14PM -0800, Justin Pettit wrote:
> Signed-off-by: Justin Pettit <jpet...@ovn.org>
> ---

Your patches are okay, but unfortunately while testing I found an
issue which is resolved by the commit below in branch-2.11 and master:

commit 024d93f62ca7a7fef9c8fc5f69a38b60ebf7e0ab
Author: Ben Pfaff <b...@ovn.org>
Date:   Wed Nov 14 16:07:30 2018 -0800

    ofp-actions: Make all actions a multiple of OFPACT_ALIGNTO bytes.


Otherwise the ovs-testcontroller segfaults:

1275: bridge - add port after stopping controller     FAILED
(bridge.at:99)

#0  0x00007faa27ea553f in raise () from /lib64/libc.so.6
#1  0x00007faa27e8f895 in abort () from /lib64/libc.so.6
#2  0x000000000044cfab in ofputil_protocol_to_ofp_version (protocol=(unknown: 
0)) at lib/ofp-protocol.c:123
#3  0x000000000043152f in ofputil_encode_flow_mod (fm=0x7ffc00eae900, 
protocol=(unknown: 0)) at lib/ofp-flow.c:370
#4  0x0000000000409bf9 in lswitch_handshake (sw=0x1226680) at 
lib/learning-switch.c:219

Notice that protocol is zeroed. It happens when ofpact_init() is called.

branch-2.9 seems to have the bug as well but the test doesn't reproduce the
issue.

fbl

_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to