oops, thanks for pointing that out

I'll fix and resend

Darrell

On Fri, Feb 22, 2019 at 2:18 PM Ben Pfaff <b...@ovn.org> wrote:

> On Wed, Feb 20, 2019 at 08:17:19AM -0800, Darrell Ball wrote:
> > It is a day one issue that got copied to the FTP handling code.
> >
> > Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.")
> > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.")
> > CC: Daniele Di Proietto <diproiet...@ovn.org>
> > Signed-off-by: Darrell Ball <dlu...@gmail.com>
>
> Thanks for working on this!
>
> There's something goofy with the types here:
>
> ../lib/conntrack.c:1598:14: error: incorrect type in assignment (different
> base types)
> ../lib/conntrack.c:1598:14:    expected unsigned int [unsigned] [assigned]
> [usertype] csum
> ../lib/conntrack.c:1598:14:    got restricted ovs_be16
> ../lib/conntrack.c:1598:14: error: incorrect type in assignment (different
> base types)
> ../lib/conntrack.c:1598:14:    expected unsigned int [unsigned] [assigned]
> [usertype] csum
> ../lib/conntrack.c:1598:14:    got restricted ovs_be16
> ../lib/conntrack.c:1598:14: error: incorrect type in assignment (different
> base types)
> ../lib/conntrack.c:1598:14:    expected unsigned int [unsigned] [assigned]
> [usertype] csum
> ../lib/conntrack.c:1598:14:    got restricted ovs_be16
> ../lib/conntrack.c:3264:22: error: incorrect type in assignment (different
> base types)
> ../lib/conntrack.c:3264:22:    expected restricted ovs_be16 [usertype]
> tcp_csum
> ../lib/conntrack.c:3264:22:    got unsigned short
> ../lib/conntrack.c:690:39: error: incorrect type in assignment (different
> base types)
> ../lib/conntrack.c:690:39:    expected restricted ovs_be16 [usertype]
> icmp6_cksum
> ../lib/conntrack.c:690:39:    got unsigned short
>
> Thanks,
>
> Ben.
>
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to