Thanks, Ben! I was thinking there'll be additional test cycles to check for regression before making it to the code. From my side, I have tested it for the new feature, compatibility and run the OVN community tests (plus testing in our setup for OVN functionality).
How do I monitor for regressions, if any? Sorry if it is obvious, i haven't pushed any changes to OVS prior to this. thanks again, -venu ________________________________________ From: Ben Pfaff <b...@ovn.org> Sent: Friday, February 22, 2019 1:47 PM To: Venugopal Iyer Cc: Guru Shetty; Leonid Grossman; d...@openvswitch.org Subject: Re: [ovs-discuss] [ovs-dev] Geneve remote_ip as flow for OVN hosts I applied this series to master. Thank you! On Tue, Feb 12, 2019 at 03:52:48PM +0000, Venugopal Iyer wrote: > HI, Ben: > > ________________________________________ > From: Ben Pfaff <b...@ovn.org> > Sent: Monday, February 11, 2019 5:55 PM > To: Venugopal Iyer > Cc: Guru Shetty; Leonid Grossman; d...@openvswitch.org > Subject: Re: [ovs-discuss] [ovs-dev] Geneve remote_ip as flow for OVN hosts > > On Mon, Feb 11, 2019 at 08:09:59PM +0000, Venugopal Iyer wrote: > > Of course we want users to upgrade the entire system. We just need to > > make sure that it's possible to upgrade one piece at a time in an order > > that ensures that the system isn't broken by a partial upgrade. The > > specified order for OVN is to upgrade the HVs first, then the central > > node. (Although apparently some people want to do it in the other > > order, which is currently a problem.) > > > > <vi> Thanks, I have updated the repo to squash all the commits and added a > > high > > <vi> level commit message. Please let me know if the message is helpful > > and/or if > > <vi> there are some best practices that I should follow. FYI, branch > > mvtep-br > > <vi> @ https://github.com/iyervl/nv-ovs > > Thanks for the revision. > > It's not clear to me whether you believe that the upgrade compatibility > issue is fixed. Is it? > > <vi> Sorry, it was not clear. Yes, it is fixed, specifically changes in > <vi> ovn/controller/binding.c, L398-400, L413 and L547. Let me know > <vi> if you have questions. > > thanks, > > -venu > > Thanks, > > Ben. > > ----------------------------------------------------------------------------------- > This email message is for the sole use of the intended recipient(s) and may > contain > confidential information. Any unauthorized review, use, disclosure or > distribution > is prohibited. If you are not the intended recipient, please contact the > sender by > reply email and destroy all copies of the original message. > ----------------------------------------------------------------------------------- _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev