On Feb 28, Ben Pfaff wrote: > On Wed, Feb 27, 2019 at 07:01:10PM +0100, Lorenzo Bianconi wrote: > > Select a random IPAM mac_prefix if it has not been provided by the user. > > With this patch the admin can avoid to configure mac_prefix in order to > > avoid L2 address collisions if multiple OVN deployments share the same > > broadcast domain. > > Remove MAC_ADDR_PREFIX definitions/occurrences since now mac_prefix is > > always provided to ovn-northd > > > > Tested-by: Miguel Duarte de Mora Barroso <mdbarr...@redhat.com> > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com> > > --- > > Changes since v2: > > - add automatic test case > > > > Changes since v1: > > - add entry in NEWS > > - do not modify the idl object in-place but update it running > > nbrec_nb_global_set_options > > It looks to me like this puts a full MAC address in options:mac_prefix, > like xx:xx:xx:xx:xx:xx. The documented format for this setting is just > xx:xx:xx: > > <column name="options" key="mac_prefix"> > Configure a given OUI to be used as prefix when L2 address is > dynamically assigned, e.g. <code>00:11:22</code> > </column>
Hi Ben, thx for the review, I will post a v4 fixing this. > > On upgrade, I think that this will suddenly change the MAC addresses of > all the VMs. Is there a way to avoid that? Should we add a release > note? > Do you mean after the upgrade if mac_prefix has not previously set? I added an entry in NEWS but maybe we can add a way to disable it (something like 'legacy mac_prefix'), what do you think? Regards, Lorenzo
_______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
