On 16.03.2019 0:05, Ben Pfaff wrote:
> Doesn't seem particularly useful to me, I suggest that we remove it
> entirely instead.

OK. I thought about removing too.
I'll send v2.

> 
> On Fri, Mar 15, 2019 at 06:21:40PM +0300, Ilya Maximets wrote:
>> s/dubug/debug/
>>
>> On 15.03.2019 17:06, Ilya Maximets wrote:
>>> This information is useful only for parser debugging.
>>> No need to print it each time to the logs.
>>>
>>> CC: Ben Pfaff <b...@ovn.org>
>>> Fixes: d1fd1ea91242 ("ovs-dpctl: New --names option to use port names in 
>>> flow dumps.")
>>> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
>>> ---
>>>  lib/dpctl.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/lib/dpctl.c b/lib/dpctl.c
>>> index edb753cb4..d60ce1e73 100644
>>> --- a/lib/dpctl.c
>>> +++ b/lib/dpctl.c
>>> @@ -2584,8 +2584,8 @@ dpctl_unixctl_handler(struct unixctl_conn *conn, int 
>>> argc, const char *argv[],
>>>      if (!set_names) {
>>>          dpctl_p.names = dpctl_p.verbosity > 0;
>>>      }
>>> -    VLOG_INFO("set_names=%d verbosity=%d names=%d", set_names,
>>> -              dpctl_p.verbosity, dpctl_p.names);
>>> +    VLOG_DBG("set_names=%d verbosity=%d names=%d", set_names,
>>> +             dpctl_p.verbosity, dpctl_p.names);
>>>  
>>>      if (!error) {
>>>          dpctl_command_handler *handler = (dpctl_command_handler *) aux;
>>>
> 
> 
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to