On 22.03.2019 16:08, Van Haaren, Harry wrote: > Hey Eelco, > >> -----Original Message----- >> From: Eelco Chaudron [mailto:echau...@redhat.com] >> Sent: Friday, March 22, 2019 12:29 PM >> To: Van Haaren, Harry <harry.van.haa...@intel.com> >> Cc: ovs-dev@openvswitch.org; i.maxim...@samsung.com >> Subject: Re: [ovs-dev] [PATCH v5 3/3] dpif-netdev: split out generic lookup >> function >> >> On 25 Feb 2019, at 17:18, Harry van Haaren wrote: >> >>> This commit splits the generic hash-lookup-verify >>> function to its own file. In doing so, we must move >>> some MACRO definitions to dpif-netdev.h >> >> Changes look good, but want to wait for some performance numbers before >> ack’ing the series. >> >> Did you do any performance tests on the change? It does not seem to >> impact much, but I’ve been surprised before. > > Thanks for the review - I'll take the comments into account for the V+1. > > Regarding performance, I expect there to be no performance delta with > this patchset - it is just enabling flexibility in the dpcls infrastructure. > > As presented at OvS conf last November, with the flexibility mentioned above > we can select optimized implementations at runtime, and that is where the > performance gains will be seen. > > > I'll work on addressing your comments early next week - thanks again! -H
Hi Harry, I didn't look at this series closely yet. But if you're going to prepare new version, it'll be good to fix checkpatch issues reported by 0-day robot too: https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356615.html https://mail.openvswitch.org/pipermail/ovs-dev/2019-February/356616.html BTW, commented out counters looks suspicious. Best regards, Ilya Maximets. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
