On Tue, Mar 26, 2019 at 05:57:09PM -0300, Flavio Leitner wrote: [...] > diff --git a/net/netfilter/nf_conntrack_helper.c > b/net/netfilter/nf_conntrack_helper.c > index 274baf1dab87..883a8d438503 100644 > --- a/net/netfilter/nf_conntrack_helper.c > +++ b/net/netfilter/nf_conntrack_helper.c > @@ -42,6 +42,9 @@ module_param_named(nf_conntrack_helper, > nf_ct_auto_assign_helper, bool, 0644); > MODULE_PARM_DESC(nf_conntrack_helper, > "Enable automatic conntrack helper assignment (default 0)"); > > +static struct list_head nf_ct_nat_helpers __read_mostly; > +static DEFINE_SPINLOCK(nf_ct_nat_helpers_lock);
Why a spinlock here? Use mutex instead I'd suggest. Thanks. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
