Hi Chris, We missed a reply from Ben.
Thanks, Roi On 23/02/2019 00:31, Ben Pfaff wrote: > On Fri, Feb 22, 2019 at 10:10:16AM +0800, Chris Mi wrote: >> If tunnel device dst_port is not the default one, "ovs-dpctl dump-flows" >> will fail. The error message for vxlan is: >> >> netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No >> such device >> >> That's because when calling netdev_vport_construct() for netdev >> vxlan_sys_xxxx, the default dst_port is used. Actually, the dst_port >> value is in the netdev name. Use it to avoid the error. >> >> Signed-off-by: Chris Mi <[email protected]> >> Reviewed-by: Roi Dayan <[email protected]> >> --- >> >> v1 >> == >> >> Any comment about this patch? We are not sure if it is correct >> to verify the port from the name. If it is correct, is it applicable >> for other tunnels? Thanks! >> >> v2 >> == >> >> Apply the same fix to other tunnel types according to Flavio Leitner's >> comment. > > Thanks for the patch! > > It looks to me that if 'name' and 'dpif_port' are exactly the same, then > this code will read past the null terminator in 'dpif_port': > + if (!strncmp(name, dpif_port, strlen(dpif_port))) { > + p = name + strlen(dpif_port) + 1; > + port = atoi(p); > + } > > Thanks, > > Ben. thanks > _______________________________________________ > dev mailing list > [email protected] > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fmailman%2Flistinfo%2Fovs-dev&data=02%7C01%7Croid%40mellanox.com%7C8f2606644f12424838bd08d69915ee86%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636864716813284651&sdata=qV4EkAL6jHroYEOGlZkv3YLuZelEc6E8osQDa%2FPD18Y%3D&reserved=0 > _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
