On Thu, Mar 28, 2019 at 10:37:00AM +0000, [email protected] wrote:
> From: Lucas Alvares Gomes <[email protected]>
> 
> This patch is adding support for Transport Zones. Transport zones (a.k.a
> TZs) is way to enable users of OVN to separate Chassis into different
> logical groups that will form tunnels only between members of the same
> group(s).

Thanks for working on this.

This adds a new property to a Chassis and implements that property
through the Chassis record's external-ids.  This strikes me as a
layering violation, because external-ids is usually reserved for higher
layers in the system.  Its documentation says:

              external_ids: map of string-string pairs
                     Key-value  pairs for use by the software that manages the
                     OVN  Southbound  database   rather   than   by   ovn-con‐
                     troller/ovn-controller-vtep.  In  particular,  ovn-northd
                     can use key-value pairs in this column to relate entities
                     in the southbound database to higher-level entities (such
                     as entities in the OVN Northbound  database).  Individual
                     key-value  pairs in this column may be documented in some
                     cases to aid in understanding  and  troubleshooting,  but
                     the  reader should not mistake such documentation as com‐
                     prehensive.

It would be a more natural fit to add a transport_zones column to the
Chassis table.  (Probably a "set of strings" instead of a
comma-delimited string.)

The new property should be documented in ovn-sb.xml.

Thanks,

Ben.
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to