On 15.04.2019 22:35, Ben Pfaff wrote:
> On Mon, Apr 15, 2019 at 04:36:54PM +0300, Ilya Maximets wrote:
>> Unlike manual splitting, 'splitlines' correctly handles different
>> line endings. Without this change script fails to check files with
>> '\r\n' endings treating the whole patch as a header.
>>
>> Signed-off-by: Ilya Maximets <i.maxim...@samsung.com>
> 
> Thanks, I applied this to master.
> 
> I don't think OVS legitimately has any text files that contain carriage
> returns, so it might be worth warning about them.

'git am' by default strips '\r' symbols. OTOH, some mail clients adds them.
There might be a lot of false positives if we'll add this kind of check
to checkpatch.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to