On Fri, Apr 19, 2019 at 11:06:02PM +0530, Numan Siddique wrote: > On Fri, Apr 19, 2019 at 4:58 AM Gregory Rose <gvrose8...@gmail.com> wrote: > > > > > On 4/18/2019 2:48 PM, Ben Pfaff wrote: > > > On Tue, Apr 16, 2019 at 01:23:37PM +0530, nusid...@redhat.com wrote: > > >> From: Numan Siddique <nusid...@redhat.com> > > >> > > >> This patch adds a new action 'check_pkt_larger' which checks if the > > >> packet is larger than the given size and stores the result in the > > >> destination register. > > > Thanks for the revision! I'm taking a detailed look at this series now > > > that the datapath action is upstream and reviewed for backport. > > > > > > (In my opinion, it would be better if the datapath backport was patch 1, > > > but it is not a big deal.) > > > > > If I had to make datapath backport as patch 1, then to address the compiler > warnings, > I had to add the "case OVS_ACTION_ATTR_CHECK_PKT_LEN" in some of the switch > statements in the files like lib/dpif.c, lib/dpif-netdev.c etc. > > That's why I ordered this way and hope it's fine :).
It's fine. I'll look at the next version. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev