> On Tue, May 07, 2019 at 03:08:52PM +0200, Lorenzo Bianconi wrote:
> > Use sb mac binding table to trigger ip buffer dequeueing instead of
> > the APR/ND packet reception since the ARP reply can be managed on a
> > different chassis if a gw router port is scheduled on a different
> > node
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com>
> 
> Thanks!
> 
> buffered_mac_bindings doesn't seem to really be used as a hash table:
> nothing ever searches it.  Should it be a linked list?  Or maybe it's
> just an hmap because destroy_buffered_packets() expects that.  Not a big
> deal, just a surprise.

Hi Ben,

Thx for the fast review :)
Yes, you right. I just maintained the same code architecture. I will post a
patch to convert buffered_mac_bindings to a linked list

Regards,
Lorenzo

> 
> I don't think that really matters, and this looked good to me otherwise,
> so I applied it to master.
_______________________________________________
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to