On Fri, Jun 14, 2019 at 05:53:21PM +0200, Lorenzo Bianconi wrote: > Add Controller_Event table to OVN SBDB in order to > report CMS related event. > Introduce event_table hashmap array and controller_event related > structures to ovn-controller in order to track pending events > forwarded by ovs-vswitchd. Moreover integrate event_table hashmap > array with event_table ovn-sbdb table > > Signed-off-by: Mark Michelson <mmich...@redhat.com> > Co-authored-by: Mark Michelson <mmich...@redhat.com> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianc...@redhat.com>
Please put the functions implemented in logical-fields.h into logical-fields.c instead. To me, they don't seem like good candidates for inlining. s/responsability/responsibility/ in the docs. s/is a a/is a/ in the docs. s/duplicantion/duplication/ in the docs. OVS style for C is to always put the function name at the beginning of a line in a function definition. This code does not consistently honor that rule. The EVENT_TIMEOUT of 50,000 milliseconds seems odd. This assertion in pinctrl.c seems kind of optimistic. It will cause ovn-controller to crash if there's a bug in userdata generation, or if there's some kind of issue at upgrade. I'd prefer to avoid the potential issue (you can log a warning if you want): ovs_assert(vip && protocol && load_balancer); I don't think that the type='...' annotations are needed in the docs, since they specify the same types as in the schema itself. _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev