On Tue, Jul 9, 2019 at 5:46 PM Numan Siddique <nusid...@redhat.com> wrote:
> > > On Tue, Jul 9, 2019 at 4:37 PM Ilya Maximets <i.maxim...@samsung.com> > wrote: > >> On 01.07.2019 10:43, nusid...@redhat.com wrote: >> > From: Numan Siddique <nusid...@redhat.com> >> > >> > This patch handles sending GARPs for >> > >> > - router port IPs of a distributed router port >> > >> > - router port IPs of a router port which belongs to gateway router >> > (with the option - redirect-chassis set in Logical_Router.options) >> > >> > Signed-off-by: Numan Siddique <nusid...@redhat.com> >> > Acked-by: Dumitru Ceara <dce...@redhat.com> >> > --- >> > ovn/northd/ovn-northd.c | 44 ++++++++++++++++---- >> > tests/ovn.at | 89 +++++++++++++++++++++++++++++++---------- >> > 2 files changed, 105 insertions(+), 28 deletions(-) >> > >> >> Hi. >> This patch triggers frequent TravisCI failures: >> https://travis-ci.org/openvswitch/ovs/jobs/556015141 >> >> checking packets in ext1/vif1-tx.pcap against ext1-vif1.expected: >> ovn.at:12: waiting until $PYTHON "$top_srcdir/utilities/ovs-pcap.in" >> $rcv_pcap > $rcv_text >> rcv_n=`wc -l < "$rcv_text"` >> echo "rcv_n=$rcv_n exp_n=$exp_n" >> test $rcv_n -ge $exp_n... >> rcv_n=1 exp_n=2 >> rcv_n=1 exp_n=2 >> rcv_n=1 exp_n=2 >> rcv_n=2 exp_n=2 >> ovn.at:12: wait succeeded after 2 seconds >> ../../tests/ovn.at:8593: sort $rcv_text >> --- expout 2019-07-05 19:09:16.471288908 +0000 >> +++ >> /home/travis/build/openvswitch/ovs/openvswitch-2.11.90/_build/tests/testsuite.dir/at-groups/2662/stdout >> 2019-07-05 19:09:16.475288910 +0000 >> @@ -1,2 +1,2 @@ >> >> -f0000001020400000201020308004500001c000000003f110100c0a80102ac1001030035111100080000 >> >> +ffffffffffff00000201020308060001080006040001000002010203ac100101000000000000ac100101 >> >> >> ffffffffffff00000201020308060001080006040001000002010203ac100101000000000000ac100101 >> 2662. ovn.at:8422: 2662. ovn -- 4 HV, 1 LS, 1 LR, packet test with HA >> distributed router gateway port (ovn.at:8422): FAILED (ovn.at:8593) >> >> Could you, please, take a look? >> >> Some other tests are affected too, but re-check usually succeeds for them: >> 2664: ovn -- 4 HV, 3 LS, 2 LR, packet test with HA distributed router >> gateway port >> 2691: ovn -- router - check packet length - icmp defrag >> It'll be good to fix them too. >> >> > Hi Ilya, > > I will take a look at it. > Dumitru also mentioned about the same errors. I thought those are timing > related. > Let me take a look. > > I have submitted the patch to fix these test failures - https://patchwork.ozlabs.org/patch/1130867/ Thanks Numan > Thanks > Numan > > >> Best regards, Ilya Maximets. >> > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
