Thanks Ben for review! On Fri, Aug 23, 2019 at 10:42 AM Ben Pfaff <b...@ovn.org> wrote:
> On Thu, Aug 22, 2019 at 05:53:10PM -0700, amgin...@gmail.com wrote: > > From: Aliasgar Ginwala <aginw...@ebay.com> > > > > Add support in ovsdb-tool for migrating clustered dbs to standalone dbs. > > E.g. usage to migrate nb/sb db to standalone db from raft: > > ovsdb-tool migrate-cluster-db ovnnb_db.db ovnnb_db_cluster.db > > > > Signed-off-by: Aliasgar Ginwala <aginw...@ebay.com> > > In addition to Han's comments, I suggest updating the documentation, > both for ovsdb-tool itself and Documentation/ref/ovsdb.7.rst. This kind > of tool can't be sure to get an up-to-date snapshot of the database, > since it only looks at one member of the raft cluster and therefore > can't be sure about the current consensus, so it's more risky to use it > than an online operation like "ovsdb-client backup". That's probably OK > in some circumstances (notably, if the cluster is already down and can't > be easily revived), but I think that the documentation should be clear > that there is a trade-off. > Yup sure. Actually, for testing I use leader's db to avoid major drift. But overall agree as its little risky but can help in in crisis like situation if cluster is down and we want to revert to standalone mode. Will update document likewise as per your suggestion, > _______________________________________________ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
