On Fri, Sep 13, 2019 at 10:48 AM Justin Pettit <jpet...@ovn.org> wrote: > > > > On Sep 13, 2019, at 10:41 AM, William Tu <u9012...@gmail.com> wrote: > > > >> Is there a reason you limited this to 18 arguments and not use INT_MAX? > > > > I use 18 because at most we have 11 tcp, 3 udp, 2 icmp, total of 16 and plus > > (dp_name, zone_id), so total is 18. > > I think using INT_MAX is fine, because at db schema, the value type is set. > > That's a fair argument. However, I'd suggest that we let ovs-vswitchd do > that enforcement. It's nice to decouple the configuration tool from the > binary as much as possible in case people run different versions. > > > I will merge your diff and send next version. > > Sounds good. I'm hopeful that we'll be able to get this version merged with > minimal changes, though. > > Thanks,
Hi Justin, I applied your diff and it's working fine. I don't have any other change, do you want me to send another patch or you want to directly apply? Thanks William _______________________________________________ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
