On Wed, Nov 06, 2019 at 01:47:26PM -0500, Aaron Conole wrote:
> Ilya Maximets <[email protected]> writes:
> 
> > While running tests under valgrind, it could take more than 10 seconds
> > for process to disappear after successful 'ovs-appctl exit' command.
> >
> > Same applies to some other events that tests are waiting for with
> > OVS_WAIT macro.  This makes tests to fail frequently under valgrind.
> >
> > Using OVS_CTL_TIMEOUT variable instead of constant 10 seconds seems
> > reasonable to avoid this issue because it controls timeouts of all
> > control utilities and needs to be adjusted while running under valgrind
> > anyway.
> >
> > Signed-off-by: Ilya Maximets <[email protected]>
> > ---
> 
> LGTM.  But that means that the timeout will now default to taking 30s
> instead.  I think it's okay, because we can override it now.
> 
> Acked-by: Aaron Conole <[email protected]>
> 
Thank you.
I applied to master.
--William
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Reply via email to