On Mon, 11 Nov 2019 19:52:56 +0100 Ilya Maximets <[email protected]> wrote:
> The conventional way for packet dumping in OVS is to use ovs-tcpdump > that works via traffic mirroring. DPDK pdump could probably be used > for some lower level debugging, but it is not commonly used for > various reasons. > > There are lots of limitations for using this functionality in > practice. Most of them connected with running secondary pdump process > and memory layout issues like requirement to disable ASLR in kernel. > More details are available in DPDK guide: > https://doc.dpdk.org/guides/prog_guide/multi_proc_support.html#multi-process-limitations > > Beside the functional limitations it's also hard to use this > functionality correctly. User must be sure that OVS and pdump utility > are running on different CPU cores, which is hard because non-PMD > threads could float over available CPU cores. This or any other > misconfiguration will likely lead to crash of the pdump utility > or/and OVS. > > Another problem is that the user must actually have this special pdump > utility in a system and it might be not available in distributions. > > This change disables pdump support by default introducing special > configuration option '--enable-dpdk-pdump'. Deprecation warnings will > be shown to users on configuration and in runtime. > > Claiming to completely remove this functionality from OVS in one > of the next releases. > > Signed-off-by: Ilya Maximets <[email protected]> > Acked-by: Aaron Conole <[email protected]> > --- > > Version 1: > * No changes since RFC. > * Added ACK from Aaron. > > .travis/linux-build.sh | 4 +++- > Documentation/topics/dpdk/pdump.rst | 8 +++++++- > NEWS | 4 ++++ > acinclude.m4 | 24 ++++++++++++++++++------ > lib/dpdk.c | 2 ++ > 5 files changed, 34 insertions(+), 8 deletions(-) New option noted in NEWS, warning for those users enabling the option, documentation updated. LGTM Acked-by: Flavio Leitner <[email protected]> _______________________________________________ dev mailing list [email protected] https://mail.openvswitch.org/mailman/listinfo/ovs-dev
