On Wed, Nov 20, 2019 at 11:25:12AM -0800, Ben Pfaff wrote:
> On Wed, Nov 06, 2019 at 12:35:49PM -0800, William Tu wrote:
> > On Tue, Nov 05, 2019 at 04:49:10PM -0800, Ben Pfaff wrote:
> > > On Tue, Nov 05, 2019 at 02:57:46PM -0800, William Tu wrote:
> > > > + /* ODP_SUPPORT_FIELDS */
> > > > + str_value = xasprintf("%"PRIuSIZE, odp.max_vlan_headers);
> > > > + smap_add(cap, "max_vlan_headers", str_value);
> > > > + free(str_value);
> > >
> > > I think that you can shorten the above to:
> > > smap_add_format(cap, "max_vlan_headers", "%"PRIuSIZE,
> > > odp.max_vlan_headers);
> > > and similarly for other cases.
> >
> > Yes, thank you.
> > >
> > > I think that we can improve the documentation. I'm working on a
> > > suggestion for that, please give me a while to write it up.
> >
> > Sure, I will wait.
>
> Here's my suggestion, as an incremental:
Thanks a lot for adding much better doc.
I will merge it into next version.
One comment inline below.
>
> -8<--------------------------cut here-------------------------->8--
>
> diff --git a/lib/meta-flow.xml b/lib/meta-flow.xml
> index d8763eb0b718..90b405c73750 100644
> --- a/lib/meta-flow.xml
> +++ b/lib/meta-flow.xml
> @@ -2488,7 +2488,7 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
>
> <group title="Connection Tracking">
> <p>
> - Open vSwitch 2.5 and later support ``connection tracking,'' which
> allows
> + Open vSwitch supports ``connection tracking,'' which allows
> bidirectional streams of packets to be statefully grouped into
> connections. Open vSwitch connection tracking, for example, identifies
> the patterns of TCP packets that indicates a successfully initiated
> @@ -2524,7 +2524,14 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
> </p>
>
> <p>
> - Connection tracking is an Open vSwitch extension to OpenFlow.
> + Connection tracking is an Open vSwitch extension to OpenFlow. Open
> + vSwitch 2.5 added the initial support for connection tracking.
> + Subsequent versions of Open vSwitch added many refinements and
> extensions
> + to the initial support. Many of these capabilities depend on the Open
> + vSwitch datapath rather than simply the userspace version. The
> + <code>capabilities</code> column in the <code>Datapath</code> table
> (see
> + <code>ovs-vswitchd.conf.db</code>(5)) reports the detailed capabilities
> + of a particular Open vSwitch datapath.
> </p>
>
> <field id="MFF_CT_STATE" title="Connection Tracking State">
> @@ -2713,7 +2720,8 @@ actions=clone(load:0->NXM_OF_IN_PORT[],output:123)
> </p>
>
> <p>
> - The following fields are populated by the ct action, and require a
> + The following fields are populated by the <code>ct</code>
> + action, and require a
> match to a valid connection tracking state as a prerequisite, in
> addition to the IP or IPv6 ethertype match. Examples of valid
> connection tracking state matches include <code>ct_state=+new</code>,
> diff --git a/manpages.mk b/manpages.mk
> index 281ebd8fe946..09b0f9eccf4e 100644
> --- a/manpages.mk
> +++ b/manpages.mk
> @@ -1,23 +1,5 @@
> # Generated automatically -- do not modify! -*- buffer-read-only: t -*-
>
> -ovn/utilities/ovn-sbctl.8: \
> - ovn/utilities/ovn-sbctl.8.in \
> - lib/common.man \
> - lib/db-ctl-base.man \
> - lib/ovs.tmac \
> - lib/ssl-bootstrap.man \
> - lib/ssl.man \
> - lib/table.man \
> - lib/vlog.man
> -ovn/utilities/ovn-sbctl.8.in:
> -lib/common.man:
> -lib/db-ctl-base.man:
> -lib/ovs.tmac:
> -lib/ssl-bootstrap.man:
> -lib/ssl.man:
> -lib/table.man:
> -lib/vlog.man:
> -
> ovsdb/ovsdb-client.1: \
> ovsdb/ovsdb-client.1.in \
> lib/common-syn.man \
> @@ -116,6 +98,12 @@ lib/vlog-syn.man:
> lib/vlog.man:
> ovsdb/ovsdb-schemas.man:
>
> +utilities/bugtool/ovs-bugtool.8: \
> + utilities/bugtool/ovs-bugtool.8.in \
> + lib/ovs.tmac
> +utilities/bugtool/ovs-bugtool.8.in:
> +lib/ovs.tmac:
> +
> utilities/ovs-appctl.8: \
> utilities/ovs-appctl.8.in \
> lib/common.man \
I think the above is not related. I will remove the manpages.mk diff.
Rest below looks good to me.
--William
_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
